Update attributes.json #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrvanekrobe
force-pushed
the
Attribute-with-extended-explanation
branch
from
2b102c7 to
59baa5c
Compare
petrvanekrobe
force-pushed
the
Attribute-with-extended-explanation
branch
from
4832626 to
1abb4f7
Compare
petrvanekrobe
force-pushed
the
Attribute-with-extended-explanation
branch
from
0d2423f to
9fbdd75
Compare
|
@moritzstaffel I have rebased and resolved conflicts here. I test rebased in onto main and it applies cleanly. As i rebased it, it will be applied with correct date and attribution at the an of the commit three. Question is whether we need all the separate commits or if we want to squash the commits (attribution will be lost, unless we add Co-authored-by: to the squashed commit itself). What do you think? |
- Fixture Global Reset, Dimmer Reset, Shutter Reset, Beam Reset - Color Mix Reset, Color Wheel Reset, Focus Reset, Frame Reset - G Reset, Intensity Reset, Iris Reset, Pos Reset, Pan Reset, Tilt Reset - Zoom Reset, CTB Reset, CTO Reset, CTC Reset, Anim Sytem Reset - Fixture Calibration Reset, Function, Lamp Ctrl, Display Int, DMX Input - NoFeature, Dummy, Reflector Adj
…se, IrisPulseOpen, IrisRandomPulseClose, IrisRandomPulseOpen
…r, CRI Mode, ColorUniform, Color Ctrl Rst, ColorModel
…n existing explanations
Added Attribute explanations
…Effects, AnimationWheel(n)SelectShake, AnimationWheel(n)SelectSpin
Added explanations for 'Gobo(n)SelectSpin' and 'Gobo(n)SelectShake' attributes
added explanations for "ColorEffects(n)" and "PlaySpeed" attributes
…talZoom, ZoomModeBeam, ZoomModeSpot
petrvanekrobe
force-pushed
the
Attribute-with-extended-explanation
branch
from
18e0421 to
59908c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute file with extended explanation and links to visuals for further description...