Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session-wise preproc gets repeated when each session has multiple experiments #172

Open
mwaskom opened this issue Nov 26, 2018 · 2 comments

Comments

@mwaskom
Copy link
Owner

mwaskom commented Nov 26, 2018

This is not ideal. In the end it's not a big cost, but estimating the distortions from the fieldmaps is the slowest thing in preprocessing so re-working this would save some computation time. I'm pretty sure it's deterministic but haven't confirmed — if not, it's a bigger problem. But improving this would involve a fairly large reorganization of how things work, so we might just have to live with it.

@mwaskom
Copy link
Owner Author

mwaskom commented Nov 27, 2018

Maybe an easy solution is to add an experiment-level iterable in preprocessing and perform timeseries operations over it. This will duplicate data storage for the session templates, but not computation.

@mwaskom
Copy link
Owner Author

mwaskom commented Apr 26, 2019

The previous idea will not work. I explored it, but ultimately the experiment name is a property of the Info dictionary that gets passed to the preprocessing workflow. It doesn't seem possible to nest experiments at the correct level within the iterable structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant