-
Notifications
You must be signed in to change notification settings - Fork 1
Dev Meeting Notes
Ian Ward edited this page Apr 24, 2014
·
32 revisions
- Chair
- seanh
- Notes
- Ian
- #1667 break long title words - nigel to review
- #1666 fix for serious errors to data pusher - need a decision on front end tests to add a test, joe to review
- #1503 two-licenses issue - continued discussion on ambiguity, discusson to continue on pull request
- #1664 package_create/update auth fix - adria to review, sean to comment on how to add test
- #1251 resource views - continued work, adria to review
- #1663 remove repeated string - vitor assigned
- #1617 DetachedInstanceError - when new session is created old one is closed automatically, leading to a DetachedInstanceError later on, nigel has a fix but further explanation is requested. deep ckan knowledge required
- #1656 paster db clean fix - seanh assigned
- #1412 regenerate api keys - needs more tests joe reviewing, currently only usable from the front end. multiple api keys? possibly in the future
- #1668 deleted user bug - nigel assigned
- #1665 group auth for logged in user - possibly not complicated to implement, need to investigate why feature was removed in the first place - vitor volunteered
- #1662 can't deprecate with maintain.deprecated - likely decorator broken on object or controller method, possibly not designed for use around actions - joe to take a look
General Questions:
- joet: turn off openid by default? - to proceed
- joet: passlib is ok? https://github.com/ckan/ckan/pull/1658 agreed a great idea, work to continue and multiple reviewers to be requested when ready
- nigel: email hash https://github.com/ckan/ckan/pull/1657 helper function vs. special context vs. sysadmin access to user_list action, nigel to work on removing from api while still supporting gravatar in the user list controller
- seanh: DetachedInstanceError questions, discussion of controller, logic, model layers. discussed adding to description to contribting docs along with guidance about how to avoid replicating old code. session and model objects in context? are they singletons? No: session is per-request. model is passed because model.session might create a new session or return the existing one. model is also possibly good for mocking in tests.
- Chair
- Adria
- Notes
- Ian
- #1656 joe to add some notes to docstring
- #1412 joe to look at it
- #1617 ready for review, assigned to sean
- #1655 nigel assigned
- #1654 wardi assigned
- #1652 nigel assigned
- #1651 ubuntu 14.04 LTS support, ongoing
General Questions:
- nigelb: Documentation or UI for revisions. https://github.com/ckan/ideas-and-roadmap/issues/41 proposal to merge the revision information into the activities. First, revision/diff page can be resurrected https://github.com/ckan/ideas-and-roadmap/issues/33 https://github.com/ckan/ckan/pull/1590 based on activity and resource data that already exists in the database
- amercader: coveralls comments: can we turn them off? coveralls creates a lot of noise in emails, particlarly for small changes. can we set a threshold for the % change that creates an notification? yes https://coveralls.io/docs/notifications can we get notifications if it drops below 80%? vitor to investigate
- wardi: workflow plugins based on activities model: https://github.com/ckan/ideas-and-roadmap/issues/45 the future! we just need funding (wardi) JSON Patch is a thing and has a python implementation http://jsonpatch.com/ https://tools.ietf.org/html/rfc6902
- vitor: pull requests that lower our test coverage implement a policy on acceptance of patches that lower coverage? vitorbaptista is going to write some guidelines into the contributing docs and core devs will be stricter with their own PRs
- Chair
- Adria
- Notes
- Nigel
- #1251: sean is looking
- #1641: still WIP.
- #1550: nigel still working
- #1539: adria got volunteered at the last meeting
- #1649, #1648, #1647: All of them are correct. Someone needs to review and fix it. We'll ask Ross to take a look and review on Tuesday again if he doesn't want to.
- #1646: nigel
- #1643: It may potentially need to be removed. A type of homepage might show facets, need digging. This also assumes that there's only one type of package. It could be used in a different type of home page. We could change it so that you can request facets instead of having them declared in your controller.
General Questions:
-
CLA Feedback.
- Background: As we started the CKAN Association and moved to encouraging more contributions - we needed to get the legal status of CKAN core code on better footing. We (mostly Ira) explored both licence agreements and copyright assignments. Legally we are better protected with copyright assignment (presenting a united front to any who may want to challenge / sue), but data.gov.uk and others presented a strong preference for licencing agreement instead. We also reviewed all the various options that other open source projects and foundations use (usually a mix of the two). Ira talked lots to the JQuery Director who both have copyright assignement (for core devs) and licence agreements for others. After talking to the OKF lawyer, we decided to re-use their agreement (see here: http://contribute.jquery.org/CLA/) which they gave us permission for, with a few small tweaks our lawyer suggested. This meant that we take on less risk, using an agreement that already exists and has been used ‘in the wild’ and hence has set a precedent for how any legal challenges and complications are handled and how well this stands up in court etc.
- From Meeting: We all agree that we need but the proposed one has issues raised on the repo. The issues raised are not resolved yet. The issues would prefer to be closed when the person who opened it is happy with the response, but we shouldn't bikeshed and decide on a process. Rufus has responded and the dev team will chase it. Most people who have contributed have been employed by Open Knowledge, so historical contributors aren't that big of a problem. Going forward, we need to get it setup for new people contributing. How does this affect extensions? How are things on github.com/ckan considered core and do we make github.com/ckan similarly licensed and marked as core? Extensions need to be published anyway under AGPL. Someone that has been given the CKAN produce re-licensed would have difficulty with extensions. Anyone who created an issue on the cla needs to reply about issue, so we can keep the discussion moving. nigel to arrange meeting to discuss remaining issues in 2 weeks.
- Office hours. Rufus suggested and the people who want to come in are not peple who want to discuss things. Related issue people in the US who want to make it to the meetings, but the meetings are difficult for the US. From a user POV, this is great, but dev POV, this may end up being dedicated support time. The name is important and "office hours" might convey the wrong meaning. The discussions that we wanted part of it sounded good. Rufus is willing to step up and run a community hangout but needs someone from the tech team to help out. People should propose what they want to talk about. Ira suggested that this needs to be about QA, roadmap, etc. We generally think this is a good idea.
- (adam) Persistent Hangout? Adam to setup a persistent hangout. - https://plus.google.com/hangouts/_/okfn.org/ckan-dev-call
- (amercader) Supporting Ubuntu 14.04. Should we support 12.04 and 14.04 at the same time? It also switches to Python 3. Adria will create a new issue and we can start tracking this in there. Do we drop support for 12.04? We can't drop support easily. We could perhaps setup travis for 14.04 and also think about packages.
- (ira) Frequency of server or internal errors on demo; is this across all of ckan? who looks at logs? why is this so flaky? Demo is flaky for various reasons. Nigel to talk to Ira. David suggested setting up sentry.
- (amercader) 2.2.1 needs to happen. There are enough bugs to justify this. If you think something needs to be backported, tag it as such.
- (ira) possible for previews for what the resource file looks on the dataset page. Like a thumbnail of it. Potentially a great extension. If there's already a graph, a thumbnail of it will be really engaging. Potentially do it from a datapusher sort of thing in an extension. Ira to go and get lots of money to get it done!
- (wardi) moar cla discussion (only if there is time). Ian talked to devs at open contracting. They had seen CKAN but thought it was way too complicated and used Django instead. There wasn't a lot of compelling reasons. This adds danger to CKAN as a project. That'll give competitors the advantage. The copyright assignment bits are the dangerous bits. Was the lawyer's concern about copyright assignment? Copyright is not a very good open source citizen thing to do. The lawyer said this is the most legally defensible position. It is what others are using. It's not balanced, OKF has more rights than everyone else. Copyright assignment vs licencing. In a CLA, you give license, not give copyright. The difference is whether you actually assign copyright.
If there's a chance of someone going to pay to relicense CKAN, it's enough money to rewrite the whole thing. Ira is fairly happy as long as we have some clarity. Ira will look at DCO and see if it meets the things that Ira was worried about. Recommended reading: https://github.com/ckan/cla/issues/2. It's important to capture the questions and motivations of the CLA.
- Chair
- Nigel
- Notes
- Everyone
- #1641 resource_create should break when called without URL (vitorbapista)
- #1644 - add xlsx tsv to datapusher defaults (joet)
- #1617 - detached instance error (seanh)
- #1646 - nigelb will reply
- #1645 - should be part of a larger discussion about the api, is it consistent with package_show, user_list, etc. The count of the number of packages should be consistent as well, and not clash with another field in another api call - wardi
- #1643 - seanh
General Questions:
- (amercader) Meeting notes to wiki: Tricky, as no easy way to export to Markdown. Tried this but not great, as issues #xxx are translated as headings. Perhaps Etherpad allows export to Markdown? - (generally agreed)
https://docs.google.com/document/d/1MRNmhqBthZILBF8oG1NkwmyofRfOXr3NRJA1CCuHVD4/pub