Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Do not allow null key or null value to be added to cache fixes #152 #165

Merged
merged 1 commit into from
Nov 4, 2023
+5 −2
Merged

[fix] Do not allow null key or null value to be added to cache fixes #152 #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/org/mybatis/caches/caffeine/CaffeineCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2016-2022 the original author or authors.
* Copyright 2016-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -54,7 +54,10 @@ public String getId() {

@Override
public void putObject(Object key, Object value) {
this.cache.put(key, value);
// Do not allow null values to be cached as not allowed in caffeine cache
if (key != null && value != null) {
this.cache.put(key, value);
}
}

@Override
Expand Down