Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Fix wrong anchor #3132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Jinops
Copy link

@Jinops Jinops commented Apr 10, 2024

Some anchor tags are not working on https://mybatis.org/mybatis-3/configuration.html.
typeAliases, typeHandlers, objectFactory, and databaseidprovider are linked to ids with wrong capitalization.
So I fixed it. 😄

Also, add missing databaseIdProvider menu on japanese language.

@Jinops Jinops changed the title Fix wrong anchor (docs) Fix wrong anchor Apr 10, 2024
@hazendaz
Copy link
Member

Seems odd to have to go to all lower case. Did this work in the past? We did upgrade to the long ongoing maven site 4.0 which has a lot of bugs as we have found out. Maven had fixed many and has a release coming out soon. I'd like to wait here unless this was always an issue and not recent in last few months.

@hazendaz hazendaz self-assigned this Apr 12, 2024
@Jinops
Copy link
Author

Jinops commented Apr 18, 2024

I'm not sure if it really worked in the past or not.
The current state is that these titles have ids in lowercase(e.g. #databaseidprovider), while some anchors try to reference #databaseIdProvider.
I know that this issue doesn't need to be handled right now. So, feel free to look into it (or not).
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants