Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a knowledge.google.setApiKey function #1

Open
ben-pr-p opened this issue Dec 20, 2018 · 1 comment
Open

Add a knowledge.google.setApiKey function #1

ben-pr-p opened this issue Dec 20, 2018 · 1 comment
Labels

Comments

@ben-pr-p
Copy link

By requiring an environment variable, you're limiting the end users configuration options and potentially forcing them to rename other google API keys that they don't want to conflict.

Easiest solution would be to have a knowledge.google.setApiKey(apiKey) function that set the API key, and fallback to GOOGLE_API_KEY otherwise.

If you agree, I'll be happy to submit the PR!

@mycaule
Copy link
Owner

mycaule commented Dec 20, 2018

Thanks for the feedback, I'll have a look and will clean the repo this Christmas holiday (update dependencies, see if I can make quick wins..).

I haven't been in this repo for a while, I didn't notice there were a few users.

If you want to do a PR I will review it. Thanks.

@mycaule mycaule added the google label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants