Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent anonymous user to generate personal access token #929

Merged
merged 9 commits into from
Oct 25, 2023
Merged

fix: prevent anonymous user to generate personal access token #929

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4a29c9
feat: add pat
RiXelanya Oct 24, 2023
5688912
fix: method type
RiXelanya Oct 24, 2023
f4582ba
Merge branch 'main' into PAT
RiXelanya Oct 24, 2023
c39cce5
format fix
RiXelanya Oct 24, 2023
c00c449
Merge branch 'PAT' of https://github.com/RiXelanya/myriad-api into PAT
RiXelanya Oct 24, 2023
850716f
Update user.service.ts
RiXelanya Oct 25, 2023
29fb211
Merge branch 'main' into PAT
RiXelanya Oct 25, 2023
e33626d
Update user.service.ts
RiXelanya Oct 25, 2023
f845174
Merge branch 'PAT' of https://github.com/RiXelanya/myriad-api into PAT
RiXelanya Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/services/user.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,16 @@ export class UserService {
);
}
const accessToken = await this.jwtService.generateToken(this.currentUser);
const user = await this.userRepository.findById(
this.currentUser[securityId],
);
if (!user) {
throw new HttpErrors.UnprocessableEntity('Unauthorized');
}
const pat = new UserPersonalAccessToken({
...data,
token: accessToken,
userId: this.currentUser[securityId],
userId: user.id,
});

return this.userPersonalAccessTokenRepository.create(pat);
Expand All @@ -332,10 +338,16 @@ export class UserService {
};
await this.userPersonalAccessTokenRepository.deleteAll(filter);
const accessToken = await this.jwtService.generateToken(this.currentUser);
const user = await this.userRepository.findById(
this.currentUser[securityId],
);
if (!user) {
throw new HttpErrors.UnprocessableEntity('Unauthorized');
}
const pat = new UserPersonalAccessToken({
...data,
token: accessToken,
userId: this.currentUser[securityId],
userId: user.id,
});

return this.userPersonalAccessTokenRepository.create(pat);
Expand Down
Loading