make it possible to use external wifi manager #1537
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @magwas |
by defining MY_EXTERNAL_WIFIMANAGER_USED
|
I believe that the cppcheck issue is not mine. If you want me to fix it, I can, though probably the code complexity does not worth that two bytes of RAM even in an embedded system. |
|
Okay, I fixed it nevertheless. Clean report is important, and disabling the warning would have been nearly as many code as fixing it the right way. And I had to look up how, so more work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by defining MY_EXTERNAL_WIFIMANAGER_USED
This makes possible to use the WifiManager library by not insisting on SSID to be defined, and not starting the wifi from the transport.