Authority performance link seems to be split in half

[WilliamWDTK]

whatdotheyknow-theme/lib/views/help/authority_performance_tracking.html.erb

Line 33 in e514cf3

<td><b><a href="/body/list/response_link"><%= pluralize(PublicBody.visible.with_tag('response_link').size, 'Authority') %></b> tagged <code>response_link</code></td>

Screencast.from.04-08-23.15.56.12.webm

(Firefox 116.0 (64-bit) Snap for Ubuntu)

[garethrees]

Ah, looks like the markup is slightly wrong (tags not closed in quite the right order) and is being fixed by the browser:

- <b><a>…</b></a>
+ <a><b>…</b></a>

To reduce some duplication and needing to fix this for every table cell, I think we could improve the generation of this page using some ruby to map the problem to tag, and then iterate through it. Here's a sketch:

<%
  table_data = {
    response_link: 'Authority releases material via a link',
    implies_webform_required: 'Authority sends a …'
    # …
  }
%>

<table>
  <thead>
    …
  </thead>
  <tbody>
    <% table_data.each do |tag, problem| %>
      <tr>
        <td>
          <%= problem %>
        </td>

        <td>
          <!-- TODO: haven't checked the actual path that's needed here -->
          <%= link_to list_public_body_path(tag) do %>
            <b><%= pluralize(PublicBody.visible.with_tag('response_link').size, 'Authority') %></b> tagged <code>response_link</code>
          <% end %>
        </td>
        
        <td>
          <!-- TODO: haven't checked the actual path that's needed here -->
          <%= link_to search_requests_path(tag: tag) do %>
            <b><%= pluralize(InfoRequest.is_public.with_tag('response_link').size, 'Request') %></b> tagged <code>response_link</code>
          <% end %>
        </td>
      </tr>
    <% end %>
  </tbody>
 </table>