Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink naming #107

Open
rklaehn opened this issue Nov 3, 2024 · 4 comments
Open

Rethink naming #107

rklaehn opened this issue Nov 3, 2024 · 4 comments

Comments

@rklaehn
Copy link
Collaborator

rklaehn commented Nov 3, 2024

Current naming is a bit confusing if you don't know QUIC. E.g. a connection is a thing that can give you bidi streams, but from TCP you would expect that a connection is a bidi stream.

So maybe Connector for the thing that has open and Acceptor for the thing that has accept?

Also, there are some old type names AcceptBiXXX or OpenBiXXX that need to be changed. The Bi can go, connections are always bidirectional.

@rklaehn
Copy link
Collaborator Author

rklaehn commented Nov 4, 2024

The XBiY thing is taken care of in the map refactor PR.

@l-7-l
Copy link

l-7-l commented Nov 10, 2024

I think this project is a great and promising project, covering the growth from modular monolith to microservices, and the name is actually good enough.
My suggestions:

  1. Publish some introduction and performance comparison articles in communities such as reddit hacknews twitter This Week in Rust and other platforms for promotion
  2. Why not unify the error handling of the server and client, and force the server to return Result?

@matheus23
Copy link
Contributor

the name is actually good enough

Yeah - this issue is more about the naming of structs inside quic-rpc and less about the name quic-rpc itself.

Publish some introduction and performance comparison articles in communities such as reddit hacknews twitter This Week in Rust and other platforms for promotion

This is actually something amazing that you can contribute!
We might consider doing something like that too, but if you, personally, feel like this is needed and want to put some time into this, then that'd be a great contribution.

@l-7-l
Copy link

l-7-l commented Nov 11, 2024

@matheus23 I'm sorry I'm not good at this. I'm new backend developer and my English is very poor.

thanks for the great works and have a niiiice day~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants