Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm-publish-link-builder.yml and merge with npm-publish.yml #11

Open
aminjafer-n3o opened this issue Jun 7, 2024 · 0 comments
Open
Assignees

Comments

@aminjafer-n3o
Copy link
Contributor

I need to come back to this and merge both into the same npm-publish but there are two challenges:

  • The command for npm version is requiring the additional flag for --git-tag-version when trying to publish the link builder repo. We can maybe add this flag to the npm-publish.yml anyway since it should not affect current functionality of the workfow.
  • The project structure for the Link Builder is quite different than for n3ojs and does not require the second prepack step in the npm-publish.yml workflow. We might need to adjust the npm-publish.yml to have a second optional parameter set to true by default and when invoke from linkbuilder we set it to false, then use this in the if condition for the second prepack step in npm-publish.yml.
@aminjafer-n3o aminjafer-n3o self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant