Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropdown to work in Flatlist Item #269

Open
silviosampaio opened this issue Apr 28, 2021 · 0 comments
Open

Fix Dropdown to work in Flatlist Item #269

silviosampaio opened this issue Apr 28, 2021 · 0 comments

Comments

@silviosampaio
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-material-dropdown/src/components/dropdown/index.js b/node_modules/react-native-material-dropdown/src/components/dropdown/index.js
index b1e65a1..4ddcdb7 100644
--- a/node_modules/react-native-material-dropdown/src/components/dropdown/index.js
+++ b/node_modules/react-native-material-dropdown/src/components/dropdown/index.js
@@ -14,6 +14,7 @@ import {
 } from 'react-native';
 import Ripple from 'react-native-material-ripple';
 import { TextField } from 'react-native-material-textfield';
+import { TouchableOpacity } from 'react-native-gesture-handler'
 
 import DropdownItem from '../item';
 import styles from './styles';
@@ -79,7 +80,7 @@ export default class Dropdown extends PureComponent {
   };
 
   static propTypes = {
-    ...TouchableWithoutFeedback.propTypes,
+    ...TouchableOpacity.propTypes,
 
     disabled: PropTypes.bool,
 
@@ -726,12 +727,12 @@ export default class Dropdown extends PureComponent {
 
     return (
       <View onLayout={this.onLayout} ref={this.updateContainerRef} style={containerStyle}>
-        <TouchableWithoutFeedback {...touchableProps}>
+        <TouchableOpacity {...touchableProps}>
           <View pointerEvents='box-only'>
             {this.renderBase(props)}
             {this.renderRipple()}
           </View>
-        </TouchableWithoutFeedback>
+        </TouchableOpacity>
 
         <Modal
           visible={modal}

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant