Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: md5 not empty when content is empty #779

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: md5 not empty when content is empty #779

merged 1 commit into from
Oct 11, 2024

Conversation

EndlessSeeker
Copy link

  • Md5 is not empty when the content of dataId is empty, which causes high frequency calls for nacos server after dataId is deleted.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@EndlessSeeker EndlessSeeker force-pushed the fix_delete_key_polling branch from a724756 to de5251b Compare October 11, 2024 09:32
binbin0325
binbin0325 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 7b95c9d into nacos-group:v1.x-dev Oct 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin0325 binbin0325 binbin0325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EndlessSeeker @CLAassistant @binbin0325