Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Rename files the downloaded files as orginal file names instead of number #55

Open
rsaurav12 opened this issue Sep 27, 2024 · 10 comments

Comments

@retardgerman
Copy link

I opened a PR #57!:D Should fix that.

@rsaurav12
Copy link
Author

Hi, i want to know it fixed?

@retardgerman
Copy link

Hi, i want to know it fixed?

You may use my fork as long you are waiting for approval of my PR :)

@rsaurav12
Copy link
Author

rsaurav12 commented Sep 28, 2024

U did a awesome job! But i'm facing some issues:

  1. I think some files are missing total number of images extracted from ur repo are 377 and in the following repo total images are 380:
    https://github.com/anthonywww/mksld

  2. Some files are not renamed properly
    For eg.
    Saved image to /content/mkbsd/downloads/vasjenkatro/08.png
    🔍 Found image URL!
    🖼️ Saved image to /content/mkbsd/downloads/vasjenkatro/03.png
    🔍 Found image URL!
    🖼️ Saved image to /content/mkbsd/downloads/vasjenkatro/10.png
    🔍 Found image URL!
    🖼️ Saved image to /content/mkbsd/downloads/vasjenkatro/06.png
    🔍 Found image URL!
    🖼️ Saved image to /content/mkbsd/downloads/vasjenkatro/11.png
    🔍 Found image URL!
    🖼️ Saved image to /content/mkbsd/downloads/vasjenkatro/07.png
    🔍 Found image URL!

@retardgerman
Copy link

retardgerman commented Sep 28, 2024

Thank you!

I'll check the scripts again to see what the problem is. Are you running the Python or the JS?

With the naming I'm actually not sure, if those are the actual names and that's why they are named eg. "1.png". But let me check that. Thanks for your feedback.

@inuzen
Copy link

inuzen commented Sep 28, 2024

@rsaurav12 you can check my issue here #46
might be what you are looking for

@rsaurav12
Copy link
Author

rsaurav12 commented Sep 28, 2024

Thank you!

I'll check the scripts again to see what the problem is. Are you running the Python or the JS?

With the naming I'm actually not sure, if those are the actual names and that's why they are named eg. "1.png". But let me check that. Thanks for your feedback.

Your welcome and i'm running python on google collab

@rsaurav12
Copy link
Author

@rsaurav12 you can check my issue here #46 might be what you are looking for

Can you create a python script pls

@retardgerman
Copy link

Thank you!
I'll check the scripts again to see what the problem is. Are you running the Python or the JS?
With the naming I'm actually not sure, if those are the actual names and that's why they are named eg. "1.png". But let me check that. Thanks for your feedback.

Your welcome and i'm running python on google collab

So I've just checked again. The images with the digits in their names are actually called like that in the source.

As for the number of images, it depends on what data you pull from the json. In my script, only the images marked dhd do get downloaded. If you want to load others, you would have to change the script, but I've not tested that yet.

@rsaurav12
Copy link
Author

rsaurav12 commented Sep 28, 2024

Thank you!
I'll check the scripts again to see what the problem is. Are you running the Python or the JS?
With the naming I'm actually not sure, if those are the actual names and that's why they are named eg. "1.png". But let me check that. Thanks for your feedback.

Your welcome and i'm running python on google collab

So I've just checked again. The images with the digits in their names are actually called like that in the source.

As for the number of images, it depends on what data you pull from the json. In my script, only the images marked dhd do get downloaded. If you want to load others, you would have to change the script, but I've not tested that yet.

Yeah i understood , but acc. to this repo :
https://github.com/anthonywww/mksld
This repo extract only dhd images , u can check its python script also .. idk why it's pulling more images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants