-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename function and add logger #60
base: main
Are you sure you want to change the base?
Conversation
@devloai Can you continue the development of this PR after resolving the conflict and make sure tracing and logging are working. |
Roger that! I'll resolve the conflicts and complete the tracing/logging implementation. Working on it now. 👨💻 Status: Done. |
I've completed the development work on this PR. Here's a summary of what has been accomplished: ✅ Conflict Resolution
📝 Logging Implementation
🔍 Tracing Setup
🧪 Testing & Verification
All changes have been pushed to the branch. The PR is now ready for review and meets all the requirements for both logging and tracing functionality while maintaining the application's core features and security. |
@devloai i don't need metrics but ci fails after removing it. Please fix it 🙏 |
I'll look into the CI failure and fix the metrics-related dependencies 👍 Status: Done. |
I've fixed the CI failure after removing the metrics: ✅ Root cause: Found an unused import ✅ Fix applied:
✅ Verification:
The CI should now pass. Let me know if you need anything else! |
@devloai I got "failed to upload metrics: Post "https://localhost:4318/v1/metrics": dial tcp 127.0.0.1:4318: connect: connection refused" when running on Cloud Run. Is there anything necessary to resolve this issue? |
The error occurs because the OpenTelemetry SDK is trying to send metrics to a local OTLP collector at localhost:4318 by default. On Cloud Run, we need to configure it to send metrics directly to Cloud Monitoring. You can resolve this by setting the env:
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: "https://cloudtrace.googleapis.com:443"
# Authentication is handled automatically by Cloud Run
# if the service account has the cloudtrace.agent role Also, I notice the metrics export code is currently commented out in Make sure your service account has the |
why
what
ref
roles/cloudtrace.agent