Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ncp11 for macOS after refactor+testing #155

Open
JeremyRand opened this issue Sep 8, 2021 · 0 comments
Open

Re-enable ncp11 for macOS after refactor+testing #155

JeremyRand opened this issue Sep 8, 2021 · 0 comments

Comments

@JeremyRand
Copy link
Member

As agreed on IRC, we are going to suspend RBM builds of ncp11 for macOS, because the build fails with current upstream tor-browser-build, and we do not have testing infrastructure in place to properly ensure that fixing the build does not break things elsewhere.

We do not believe this will impact users, as we believe the number of users in the wild who are using ncp11 on macOS is exactly zero.

After the p11mod refactor of ncp11 is complete, and we have testing infrastructure available to make sure that the RBM builds work on macOS, we will resume RBM builds of ncp11 for macOS. This issue will be used to track the efforts to re-enable it.
JeremyRand added a commit to JeremyRand/ncdns-repro that referenced this issue Sep 8, 2021
@JeremyRand
plain-binaries: Disable ncp11 on macOS
5da7eae 
Refs namecoin#155
JeremyRand added a commit to JeremyRand/ncdns-repro that referenced this issue Sep 8, 2021
@JeremyRand
Cirrus: Remove ncp11 tasks
05e3315 
On Windows+Linux, they will be absorbed into plain-binaries; on macOS,
ncp11 builds are suspended.

Refs namecoin#155
@JeremyRand JeremyRand mentioned this issue Sep 8, 2021
Merged
JeremyRand added a commit that referenced this issue Sep 8, 2021
@JeremyRand
Merge #156: Disable ncp11 on macOS
d1d7ff3 
05e3315 Cirrus: Remove ncp11 tasks (Jeremy Rand)
5da7eae plain-binaries: Disable ncp11 on macOS (Jeremy Rand)

Pull request description:

  Refs #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand