Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for uppercase domains #13

Open
JeremyRand opened this issue Mar 6, 2020 · 0 comments
Open

Add integration tests for uppercase domains #13

JeremyRand opened this issue Mar 6, 2020 · 0 comments

Comments

@JeremyRand
Copy link
Member

madns converts all domain names to lowercase before feeding them to ncdns: https://github.com/hlandau/madns/blob/26979b3e4b5aa3e0bd53cf0a014f9eaf43b578e3/madns.go#L126

We should add an integration test to ncprop279 that will detect if this conversion doesn't work as intended, e.g. when passed uppercase names.

Thanks to xa55 on Reddit for pointing out that this is important enough to merit an integration test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand