-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a RustCrypto based backend for cryptographic COSE operations #22
Merged
+1,367
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10322512694Details
💛 - Coveralls |
pulsastrix
commented
Aug 7, 2024
falko17
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 5 minor comments, then this should be good to go.
pulsastrix
commented
Aug 9, 2024
pulsastrix
added a commit
that referenced
this pull request
Aug 9, 2024
Co-authored-by: Falko Galperin <[email protected]>
pulsastrix
added a commit
that referenced
this pull request
Aug 9, 2024
pulsastrix
added a commit
that referenced
this pull request
Aug 9, 2024
falko17
previously approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Please rebase and then we can merge.
pulsastrix
force-pushed
the
rustcrypto_backend
branch
from
August 9, 2024 16:28
549c9dc
to
6e9b9e4
Compare
falko17
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as was done for
openssl
in #13, just based on the RustCrypto collection of crates.The easiest way of using this backend is by enabling the
rustcrypto
feature.However, if minimal binary size is desired, you can instead also limit the supported algorithms by adding only the
rustcrypto-*
features you need.Resolves #20