From cbddd15508d8985e242fa6b84c18de60507dd07d Mon Sep 17 00:00:00 2001 From: Sebastian Mitterle Date: Mon, 29 Jan 2024 10:07:54 -0500 Subject: [PATCH] blkdeviotune: improve test log The test case needs the output from 'blkdeviotune' on the disk in order to compare it with the XML values. It was trying to compare with an empty dictionary because the result was empty with an error that was ignored. Don't continue the test if the block I/O throttle parameters cannot be retrieved. This will show a test error indicating this. Signed-off-by: Sebastian Mitterle --- libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py b/libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py index 07eae2c3fc..f71634eddc 100644 --- a/libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py +++ b/libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py @@ -25,7 +25,7 @@ def check_blkdeviotune(params): vm = params.get("vm") options = params.get("blkdevio_options") device = params.get("device_name", "") - result = virsh.blkdeviotune(vm_name, device) + result = virsh.blkdeviotune(vm_name, device, ignore_status=False) dicts = {} # Parsing command output and putting them into python dictionary. cmd_output = result.stdout.strip().splitlines()