You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In napari/#7556, @psobolewskiPhD asks for a 'brief colophon' on how to make changes to icons, that could be added to the contribution guide. (Together with 'vitiate', I learned the word 'colophon' today; how exciting!)
I can work on this, but it may be useful to get input from someone else, too.
Icons (used on buttons, the logo, and some other frame stylings) are vector files saved in .svg format. Because icons in napari need to inherit styling for both light and dark appearance modes, there are a few quirks. To make icon edits, I used Inkscape (open source), but most original napari buttons were made in Adobe Illustrator. In napari/#7099@melonora also made icon edits with Inkscape. Immediate notes are the need to use undefined for stroke and fill, BUT something about this is inconsistent and I will try to solve that before making the doc contribution.
Outline
Add new page to Contributing Guide
Describe how to make icons / edit icons
Explain the code how icons inherit the appearance settings
Explain how icons are used in the napari code so that they appear on the GUI (this is not exactly easy to trace in IDEs)
The text was updated successfully, but these errors were encountered:
Even what you've written above is already a great start!
As far as I'm concerned, it's already useful, so good enough to add as a section and then can iterate.
What do you think about adding a new 'Appearance' section? This section could cover a multitude of topics including how the 'Theme' works (would be nice in tandem with How-to: Creating and testing themes), how some appearance settings work, like the font size settings (in part, that I'm working on with adding the overlay font size setting), and of course how to icons.
I found this 'Adding Icons' section in the main Contributing Guide, but it does seem a bit out of place compared to the other topics in that file. It also might not be up to date since the Qt resources don't need rebuilt (at least in a uv -e environment). @lucyleeow, could you provide any additional context to this rebuilding part? I'm not sure if you wrote it in #318, or just copied it in from a different file.
@TimMonko I didn't write that, I just copied it over. I am not well versed with Qt, sorry, can't help you there BUT I can point you to some discussions around icons, in case it's useful:
napari/napari#3136 (some discussion regarding using icon fonts vs svgs) pyapp-kit/app-model#217 - app-model now accepts svg as icons napari/napari#4860 (comment) - in the original app-model migration issue, there was an item: "add documentation explaining how to use superqt.fonticons to declare icons (and figure out the best way for those icons to change color with the theme)" though it sounds like svg is a better UX option?
📚 New content request
In napari/#7556, @psobolewskiPhD asks for a 'brief colophon' on how to make changes to icons, that could be added to the contribution guide. (Together with 'vitiate', I learned the word 'colophon' today; how exciting!)
I can work on this, but it may be useful to get input from someone else, too.
Icons (used on buttons, the logo, and some other frame stylings) are vector files saved in .svg format. Because icons in napari need to inherit styling for both light and dark appearance modes, there are a few quirks. To make icon edits, I used Inkscape (open source), but most original napari buttons were made in Adobe Illustrator. In napari/#7099 @melonora also made icon edits with Inkscape. Immediate notes are the need to use
undefined
for stroke and fill, BUT something about this is inconsistent and I will try to solve that before making the doc contribution.Outline
Contributing Guide
The text was updated successfully, but these errors were encountered: