This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Dashboard #17
Open
Dashboard #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is fucking awesomee |
|
Added some options:
You can check it by running
|
|
I can't run the dashboard from the root dir. I'd ideally run " The React.js code looks great. I don't want to nitpick but I was wondering whether hooks + functions could be used here? |
wokalski
reviewed
Sep 18, 2019
|
I try the hook/function component approach, but there the spawn wasn't worked as expected. But now we have the all of the needed bit, so I can come back and refactor it. I'll go and try what you propose and let's see 🚀 |
czystyl
commented
Sep 18, 2019
| @@ -1,13 +1,15 @@ | |||
| { | |||
| "private": true, | |||
| "scripts": { | |||
| "dashboard": "node packages/dashboard/run", | |||
There was a problem hiding this comment.
That's why you was not able to run the dashboard. Sorry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard runs 6 commands from all of the directories and shows the output.
We need to define the commands that are running in the watch mode to get the real benefit of this dashboard.close #10