Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test the output from tpc-h queries #1944

Closed
MarcoGorelli opened this issue Feb 5, 2025 · 2 comments · Fixed by #1971
Closed

test: test the output from tpc-h queries #1944

MarcoGorelli opened this issue Feb 5, 2025 · 2 comments · Fixed by #1971
Labels
good first issue Good for newcomers, but anyone is welcome to submit a pull request!

Comments

@MarcoGorelli
Copy link
Member

We currently check that each library is able to execute the tpc-h queries in CI, but don't make any assertions about the outputs

We should do that :)

contributions very welcome here
@MarcoGorelli MarcoGorelli added the good first issue Good for newcomers, but anyone is welcome to submit a pull request! label Feb 5, 2025
@FBruzzesi
Copy link
Member

I found that duckdb provides "answers" only for certain scale factors (0.01, 0.1, 1): see listing-expected-answers section.

Thoughts on:

  • change the scale factor
  • another way to generate correct output for the scale we are currently using (0.5)

@MarcoGorelli
Copy link
Member Author

0.1 is probably fine

@FBruzzesi FBruzzesi mentioned this issue Feb 8, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, but anyone is welcome to submit a pull request!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: validate tpch query results narwhals-dev/narwhals
2 participants
@MarcoGorelli @FBruzzesi