Add the option to save all temperature profiles in a climate run #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!!! @aditya-sengupta could you do me a favor and submit the PR to dev, not master! Sorry I didn't mention that before! You should be able to edit this existing PR's base merge to dev easily Also great questions about the paths. Currently the docs are built on a machine at nasa. I run all the notebooks during the build to ensure proper functionality of all parts before it goes live. Usually for file creation during a tutorial I just have it created in the same working directory for simplicity, then add the filetype to .gitignore. I think h5 files should already be ignored anyways. |
|
Noticed the 1D -> 2D change broke the convergence animation so added a fix for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213.
picaso/data/...on my machine; I could change this back but am not sure how to make the path work as it was. Is there a project convention to make paths starting with /data work, such as having /path/to/picaso in sys.path?all_profilesflattened the array of temperature profiles so that it was a 1D array of length (niter * npoints,). Changed this to be a 2D array (niter, npoints) and changedappendcalls tovstackto accommodate this. This means we can read the temperature profile at each iteration from the HDF5 file without needing to calculate indices for where each one starts.