Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear formatting Urban Cooling model equation 109 #90

Open
jagoldstein opened this issue Oct 18, 2022 · 5 comments
Open

Unclear formatting Urban Cooling model equation 109 #90

jagoldstein opened this issue Oct 18, 2022 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@jagoldstein
Copy link
Member

The Urban Cooling model's UG chapter has confusing formatting in the display of equation 109. From a readability perspective, I believe the last two terms "CCparki" and "otherwise" should be switched so that it reads:

"CCi if CCi ≥ CCparki or GAi < 2ha otherwise CCparki" .

Please check the ARG_SPECS against the source code.

@jagoldstein jagoldstein added the documentation Improvements or additions to documentation label Oct 18, 2022
@dcdenu4
Copy link
Member

dcdenu4 commented Oct 18, 2022

Thanks @jagoldstein . I'll take a look to confirm the code operates how it's described. I think equation 109 is going for style that is more apparent in equations 115 / 116. But I agree that with just two possible items like that "otherwise" doesn't really fit well there.

@dcdenu4
Copy link
Member

dcdenu4 commented Oct 18, 2022

It looks like the code is doing as expected. Here is where that equation is being implemented: ucm_source

@jagoldstein
Copy link
Member Author

it's now model equation 110

@dcdenu4
Copy link
Member

dcdenu4 commented Mar 3, 2023

Hey @jagoldstein sorry this has sat so long. I think we confirmed the source code represents what you're suggesting, so I think this is just an RST update to the UG equation. I'm happy to do it but wanted to make sure I wasn't missing something.

@jagoldstein
Copy link
Member Author

sounds good, thanks @dcdenu4 ! I don't think you're missing anything

@dcdenu4 dcdenu4 self-assigned this Mar 3, 2023
@dcdenu4 dcdenu4 added this to the 3.13.1 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants