Error handling: when saving a datastack with relative paths fails #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemfish
previously requested changes
Sep 24, 2024
There was a problem hiding this comment.
@emilyanndavis This is working exactly as described for me on Windows!
It's great to have this new error-handling in place. I had a few minor comments about try/except/else, but in general everything looks very thorough good.
…s-drive-relpath-error-handling
…s-drive-relpath-error-handling
dcdenu4
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Alright, thanks @emilyanndavis! I did a quick lookover and Dave thought it was good to go as well.
dcdenu4
approved these changes
Oct 14, 2024
dcdenu4
dismissed
davemfish’s stale review
I think we're good, Dave gave the thumbs up but can't access this PR right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1608 by logging and rendering an error message on failure to save a datastack with relative paths (e.g., when os.path.relpath raises a ValueError on Windows).
Checklist
- [ ] Updated the user's guide (if needed)datastack.build_parameter_setto raise a ValueError)