Implement observation noise for the PN likelihood #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
commented
Feb 9, 2024
just to be more aware of what acually happens
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 92.98% 93.01% +0.03%
==========================================
Files 40 40
Lines 1810 1819 +9
==========================================
+ Hits 1683 1692 +9
Misses 127 127 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option to specify an observation noise for the PN likelihood. Fixes #298.
Biggest actual change: The measurement covariance
Sis now an actual matrix, not aPSDMatrixanymore. Apparently that's good enough for our case anyways.