Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ordering of the state-space model #305

Merged
merged 23 commits into from
Feb 23, 2024
Merged

Change the ordering of the state-space model #305

merged 23 commits into from
Feb 23, 2024

Conversation

nathanaelbosch
Copy link
Owner

Fixes #302

@nathanaelbosch
Change the ordering of the state-space model: reorder the Kronecker
3be7527
@nathanaelbosch
Fix the Kronecker vectrick to do the correct thing
d4c27aa
@nathanaelbosch
Test the ldiv trick and fix it
0bd56b7
@nathanaelbosch
Make Kronecker h/v/hvcattable and change SolProj object
7aae6dd
@nathanaelbosch
Simplify and fix things that relied on the previous more complicated …
4a5fa25 
…stuff
@nathanaelbosch
JuliaFormatter.jl
cc03ef8
@nathanaelbosch
Check that ldiv actually works
c9fd071
@nathanaelbosch
Fix some issues with the prior tests
53f630c
@nathanaelbosch
Fix more stuff in the diffusion
eda4d4d
@nathanaelbosch
Make the kronecker.jl file diff smaller
a6c2d85
@nathanaelbosch
Fix more kronecker vec trick issues
61cba01
@nathanaelbosch
Rename BlockDiag into BlocksOfDiagonals, as that's what it is now
2868e9f
@nathanaelbosch
Make BlocksOfDiagonals work OK
2c331a4
@nathanaelbosch
Fix the update and smooth parts
9d39085
@nathanaelbosch
Implement hcat and vcat. THIS FIXES 2nd ORDER ODES!
46c387e
@nathanaelbosch
Add the DiagonalEK1 back into the tests!
98d3ca6
@nathanaelbosch
Add the BlockArrays extension that replaces the BlockDiagonal one
5159467
@nathanaelbosch
Fix more tests
846c2ce
@nathanaelbosch
JuliaFormatter.jl
726e073
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 94.67085% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 93.38%. Comparing base (665fdf1) to head (6f9e081).

Files Patch % Lines
src/blocksofdiagonals.jl 92.64% 15 Missing ⚠️
src/kronecker.jl 96.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   92.96%   93.38%   +0.41%     
==========================================
  Files          44       44              
  Lines        2190     2147      -43     
==========================================
- Hits         2036     2005      -31     
+ Misses        154      142      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanaelbosch nathanaelbosch marked this pull request as ready for review February 23, 2024 21:37
@nathanaelbosch nathanaelbosch merged commit 9554581 into main Feb 23, 2024
7 checks passed
@nathanaelbosch nathanaelbosch deleted the reorder-the-statespacemodel branch February 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the DiagonalEK1 work for SecondOrderODEs
1 participant
@nathanaelbosch