-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors relating to RecursiveArrayTools, Base.stack, and GaussianDistributions.jl #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 92.92% 91.84% -1.08%
==========================================
Files 44 44
Lines 2147 2219 +72
==========================================
+ Hits 1995 2038 +43
- Misses 152 181 +29 ☔ View full report in Codecov by Sentry. |
nathanaelbosch
commented
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe SciMLBase changed something about how solution indexing and plotting works, and it rougly relies on
This indexing with
indexed_solution[idxx, :]
failed on our arrays of Gaussians. After a lot of digging, I found that there were multiple issues:Gaussian
type.Base.stack
did not interact well with this.I have fixed this by removing GaussianDistributions.jl and instead implementing our own minimal Gaussian type which brings everything we need (and not much more), which could possibly me moved out into a separate SimpleGaussians.jl package in the future. According to #278 this might also fix some more type piracies (not checked yet though).
Left to do:
src/gaussians.jl
🧹