Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type piracies; upgrade to PSDMatrices v0.5.0 #316

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

nathanaelbosch
Copy link
Owner

@nathanaelbosch nathanaelbosch commented Jul 9, 2024

Fixes #278

Now that we fixed all existing type piracies we can also include Aqua.jl's piracy tests!

@nathanaelbosch nathanaelbosch marked this pull request as draft July 9, 2024 14:53
@nathanaelbosch nathanaelbosch marked this pull request as ready for review July 9, 2024 17:03
@nathanaelbosch nathanaelbosch reopened this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (2f2f6ad) to head (fd77c55).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   91.84%   91.88%   +0.03%     
==========================================
  Files          44       44              
  Lines        2219     2217       -2     
==========================================
- Hits         2038     2037       -1     
+ Misses        181      180       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanaelbosch nathanaelbosch merged commit be22a55 into main Jul 9, 2024
10 of 12 checks passed
@nathanaelbosch nathanaelbosch deleted the remove-type-piracies branch July 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix type piracies
1 participant