widen Legend patches in thinned theme

[musoke]

The thinned theme changes the size of patches in Legends. This means that the :solid, :dash and :dot lifestyles are hard to distinguish.

Widen patchsize from (8, 8)to(20, 8)`.

There may be some reason I'm unaware of for not doing this.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (e2a90b0) to head (3153918).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files           4        4           
  Lines          41       41           
=======================================
  Hits           38       38           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nathanaelbosch]

Good idea, thanks for the input! At first sight (20,8) seems a bit wide, maybe (16,8) is sufficient? Or if you have a minimal code example or some figures that show a comparison those could also be helpful to find a good value.

[musoke]

Running this script:

using CairoMakie, TuePlots, Random

data = cumsum(randn(Xoshiro(2), 4, 201), dims = 2)

for (p,) in [8, 16, 20]

    theme = merge(
        Makie.Theme(Legend = (patchsize = (p, 8),)),
        Theme(
            TuePlots.SETTINGS[:AISTATS];
            thinned = true
        )
    )

    with_theme(theme) do
        series(
            data,
            labels = ["label $i" for i in 1:4],
            linestyle=[:solid, :dash, :dot, :dashdot],
            axis=(title="patchsize = ($p, 8)",),
        )
        axislegend()

        display(current_figure())
    end
end

I got this output

In my opinion 16 is a little too narrow --- the :dash output doesn't quite have a full second dash to distinguish it from :dashdot. It might be sufficient for most cases though.

[nathanaelbosch]

Looks convincing! I'll go ahead and merge. Thanks again for the PR!