Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-ASCII characters in account names? #53

Open
lilydjwg opened this issue Apr 13, 2019 · 1 comment · May be fixed by #70
Open

Support non-ASCII characters in account names? #53

lilydjwg opened this issue Apr 13, 2019 · 1 comment · May be fixed by #70

Comments

@lilydjwg
Copy link

Hi there. I'm using Chinese in account names because a translation is not always readable and pinyin (a way to use ASCIIs when necessary) is not very readable either.

This plugin doesn't highlight such names and :AlignCommodity doesn't take this into account. Also note that Chinese characters are wider than ASCIIs.

I've replaced the regex to use \S and used strwidth to calculate and it seems to work for me, but I don't know if I missed anything.
lilydjwg added a commit to lilydjwg/dotvim that referenced this issue Apr 13, 2019
@lilydjwg
beancount: fix for Chinese account names
75c845a 
issue opened: nathangrigg/vim-beancount#53
@varac
Copy link

varac commented Oct 19, 2020

Same for german Umlauts, see screenshot:

screenshot-2020-10-19T13:28:27Z

Here's the input beanfile for reference:
utf8-test.beancount.txt

patricklucas added a commit to patricklucas/vim-beancount that referenced this issue Jul 17, 2021
@patricklucas
Support non-ASCII account names
56c072a 
This applies the changes suggested by @lilydjwg in nathangrigg#53 to support syntax
highlighting and functions against transactions with account names that
contain non-ASCII-alphanumeric characters.

With these changes, syntax highlighting, `:make`, and account name
completion work fine, so I see no reason it should cause problems.

Closes nathangrigg#53
@patricklucas patricklucas linked a pull request Jul 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support non-ASCII account names patricklucas/vim-beancount
2 participants
@lilydjwg @varac