Find-75 new accordion style to search filters #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionalarchives/ds-search into feature/search-results-layout
https://github.com/nationalarchives/ds-search into feature/FIND-75-new-accordion-style-to-search-filters base branch merge
ahosgood
reviewed
Nov 25, 2024
ahosgood
reviewed
Nov 25, 2024
ahosgood
reviewed
Nov 25, 2024
ahosgood
reviewed
Nov 25, 2024
https://github.com/nationalarchives/ds-search into feature/FIND-75-new-accordion-style-to-search-filters latest base branch
ahosgood
reviewed
Nov 26, 2024
| <div class="tna-container tna-section search-panel"> | ||
| <div class="tna-column tna-column--full-small tna-column--full-tiny tna-column--full"> | ||
| <hgroup class="tna-hgroup-l"> | ||
| <h1 class="tna-hgroup__title">Catalogue search results</h1> |
There was a problem hiding this comment.
We should only have one <h1> on the page. Should this be an <h2>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Ticket URL: https://national-archives.atlassian.net/browse/FIND-75
About these changes
Adding in the accordion element for the filters (left hand side) for the search results page
How to check these changes
Run branch locally
Check against design
https://www.figma.com/proto/YVFPU9zQzYwHmuygVE970Z/NuSearch-wireframes?page-id=0%3A1&node-id=1-84&node-type=frame&viewport=-1254%2C1621%2C0.5&t=8Jq4OudZwK4UWjbP-1&scaling=scale-down-width&content-scaling=fixed&starting-point-node-id=1%3A84
Before assigning to reviewer, please make sure you have
[x] Checked things thoroughly before handing over to reviewer
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
[x] Ensured that PR includes only commits relevant to the ticket
[x] Waited for all CI jobs to pass before requesting a review
[x] Added/updated tests and documentation where relevant