FIND-81:Add record attributes from CIIM to BE #15
+1,879
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app/records/views.py config/settings/base.py test/records/test_views.py
TNA-Allan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Ticket URL: https://national-archives.atlassian.net/browse/FIND-81
About these changes
As part of the transfer from https://github.com/nationalarchives/ds-wagtail to use Rosetta API
This PR is BE focused to getting the record attributes from API response available to use in the record details template
app/templates/records/record_detail.html. The attributes return raw data. There are separate tickets to address those attributes returning html in the data - the mark_safe/safe filter is differed until then.recordtemplate variable to use in the record details templateHow to check these changes
This PR is BE focused, it can be tested as follows-
Ref to
Catalogue Data Elementsfor record attributes and iaid exampleshttp://localhost:65533/catalogue/id/[iaid-value]/
add {{ record.[attribute-name] }} to
app/templates/records/record_detail.htmlBefore assigning to reviewer, please make sure you have