Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a consumer is deleted from the server, NACK does not recreate it #167

Closed
rozidan opened this issue Feb 5, 2024 · 8 comments · Fixed by #190
Closed

When a consumer is deleted from the server, NACK does not recreate it #167

rozidan opened this issue Feb 5, 2024 · 8 comments · Fixed by #190
Labels
defect Suspected defect such as a bug or regression

Comments

@rozidan
Copy link

rozidan commented Feb 5, 2024

What version were you using?

NACK: 0.14.1
Nats-server: 2.10.9

What environment was the server running in?

RKE2: v1.26.4+rke2r1

Is this defect reproducible?

  1. Create consumer with nack
  2. The consumer has been successfully created on the NATS server.
  3. Delete the consumer with nats-box
  4. Restart NACK

Given the capability you are leveraging, describe your expectation?

The consumer should be recreated

Given the expectation, what is the defect you are observing?

The consumer is not recreated
nack log:
"type: 'Normal' reason: 'Noop' Nothing done for consumer..."

Please see a similar issue fixed as part of #162 for streams

@rozidan rozidan added the defect Suspected defect such as a bug or regression label Feb 5, 2024
@Jarema
Copy link
Member

Jarema commented Feb 5, 2024

Thanks for opening the issue.
This is part of consideration for the Future of NACK, as right now it does not have reconcile loop.
For more details and discussion, check the discussion: #166
Feel encouraged to share you feedback there! 🙂

@jorgelon
Copy link

jorgelon commented Feb 8, 2024

same for a stream

kubectl logs nack-XXXXXXX

Nothing done for stream "XXXX" (prevent-delete=false, prevent-update=false)

I have to delete the object and recreate it

@Jarema
Copy link
Member

Jarema commented Feb 8, 2024

This is something we work on while moving forward #166

This is not a bug - the NACK does not have a reconcile loop to act on changes.
The new version of it will fully support it.

@rozidan
Copy link
Author

rozidan commented Feb 8, 2024

Will fix #162 be released for v0.14.2? If so, can a similar fix be released for consumers?

@Jarema
Copy link
Member

Jarema commented Feb 15, 2024

Yes, the fix will be part of the next release. I need to take a look into the consumer code if the same easy fix can be applied.

@svenfoo
Copy link

svenfoo commented Jun 18, 2024

Ran into this problem with v0.14.4 now. It looks like the code in consumer.go needs a similar change than what was fixed in stream.go recently.

@svenfoo
Copy link

svenfoo commented Jun 20, 2024

Yes, the fix will be part of the next release. I need to take a look into the consumer code if the same easy fix can be applied.

@Jarema Did you ever do this? To me it looks like the consumer code just needs the same easy fix. But I might be wrong, of course.

@Jarema
Copy link
Member

Jarema commented Jun 24, 2024

I realized that it was done only for streams.
Need to add the same behavior to the consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants