add deny purge property to stream spec #186
Conversation
| @@ -39,6 +39,7 @@ type sharedInformerFactory struct { | |||
| lock sync.Mutex | |||
| defaultResync time.Duration | |||
| customResync map[reflect.Type]time.Duration | |||
| transform cache.TransformFunc | |||
There was a problem hiding this comment.
@vsinger The "deny purge" specific changes look good. Can you share what this addition does and how it is used below?
There was a problem hiding this comment.
@bruth this has been generated after the local build. I think the files have not been generated since the latest dependency updates. The transform func has been added to kubernetes/client-go a while ago, see here: kubernetes/client-go@411a118
|
Hey @bruth @samuelattwood, |
|
I think we should be good to merge this. |
|
I think the PR is fine. |
|
Hey, is there a timeline when I can expect this change to show up in an actual release? AFAICT the latest (0.15.1) release is one week old and I am kind of surprised that it does not contain changes that have been merged to main for a month prior to the release |
|
Hi @Jarema, Just like v0.15.1, github claims that the tagged commit does not belong to any branch of nats-io/nack and the chain of parents of the commits is In any case the releases leave out this change and a number of dependabot updates (basically any change on main since Jul 02), so I am curious as to the rationale of these releases. Either the tags are on an accidentially unpublished branch or this may be intentional. If it is the latter could you share some insight on when th expect the changes to apeear in an release? |
|
Hey. Those are automated patch releases that just bump dependencies. |
Added possibility to set "deny_purge" property on a stream