Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Consumer Create Action #1108

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Add support for Consumer Create Action #1108

merged 3 commits into from
Apr 4, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Apr 3, 2024 •
edited
Loading

MauriceVanVeen
MauriceVanVeen approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only the tests currently failing, suggested a change to make them pass 🙂

src/test/java/io/nats/client/impl/JetStreamManagementTests.java Outdated Show resolved Hide resolved
@scottf scottf merged commit 475a02c into main Apr 4, 2024
1 check passed
@scottf scottf deleted the consumer-create-action branch April 4, 2024 19:37
@scottf scottf mentioned this pull request Apr 8, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

@mtmk mtmk Awaiting requested review from mtmk

@aricart aricart Awaiting requested review from aricart

@Jarema Jarema Awaiting requested review from Jarema

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @MauriceVanVeen