Stop requiring error kinds to impl Display #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepalez
force-pushed
the
error_kind
branch
2 times, most recently
from
cd9f19a to
97aa2cc
Compare
All kinds of `error::Error` now implements the `Display` trait, and the `Display` for the `Error` itself is inherited. The binding between the kind and `Display` is not necessary though. In this commit I dropped the restriction of error kinds by `Display`, and only implemented the trait for errors with displayable kinds. As a result, the developer got 2 options: - either to implement the `Display` for the kind (preferred), - or implement it for the error only (but not for the kind) (edge case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All kinds of
error::Error<Kind>now implement theDisplaytrait, and theDisplayfor theError<Kind>itself is inherited from itsKind.The binding between the kind and
Displayis not necessary though.In this commit I dropped the restriction of error kinds by
Display, and only implemented the trait for errors with displayable kinds. As a result, the developer got 2 options:Displayfor the kind (preferred),