Add support for EDITOR with args to commands #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Oct 22, 2024
ripienaar
reviewed
Oct 28, 2024
|
Looking good, I am slowly moving these utils into https://github.com/nats-io/natscli/blob/main/internal/util/util.go and its test to not pollute this package so much, be great to see these helpers moved there then we're good. Sorry wasn't clear in earlier review about internal |
|
Some typos also flagged by CI |
|
Ah makes sense, I will move the new util functions over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1173
Add support for EDITOR with args for commands that use EDITOR, like
nats context edit.This allows users to use something like
code --waitfor their EDITOR.