Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: switch to v2 config & GH Action #1191

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

philpennock
Copy link
Member

Handle deprecated configuration settings, updating per guidance in https://goreleaser.com/deprecations/.

Add an internal version: field in the GoReleaser YAML, for v2.

Switch the GitHub Action to @v6 which will use goreleaser v2, and make the version explicitly "~> v2". Before, it said "latest" but that was implicitly bound by the action to be v1, leading to a little head-scratching.

Handle deprecated configuration settings, updating per guidance in
<https://goreleaser.com/deprecations/>.

Add an internal `version:` field in the GoReleaser YAML, for v2.

Switch the GitHub Action to @v6 which will use goreleaser v2, and make the
version explicitly `"~> v2"`.  Before, it said "latest" but that was implicitly
bound by the action to be v1, leading to a little head-scratching.
@philpennock philpennock requested a review from ripienaar December 9, 2024 18:53
philpennock added a commit to ConnectEverything/client-tools that referenced this pull request Dec 9, 2024
 * Move schedule to be within working hours, so we get alerts on failure
 * Update GH Actions and the Go version
 * Update goreleaser version to v2
   + nsc uses goreleaser.yaml version 2
   + nats-io/natscli#1191 gets natscli to the same version
 * Support a parallelism pass-through for `goreleaser`, to avoid making my
   laptop beg for mercy while testing
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit c207757 into main Dec 9, 2024
6 checks passed
@ripienaar ripienaar deleted the pdp/goreleaser-v2 branch December 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants