Add a --match-replies-timeout to print messages without a reply. #1199
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo13
commented
Dec 13, 2024
| @@ -110,6 +111,7 @@ func configureSubCommand(app commandHost) { | |||
| // To be done - check for streams with WorkQueue, then prompt with or allow with override --force=WorkQueueDelete | |||
| // act.Flag("ackPolicy", "Acknowledgment policy (none, all, explicit) (requires JetStream)").Default("none").EnumVar(&c.ackPolicy, "none", "all", "explicit") | |||
| act.Flag("match-replies", "Match replies to requests").UnNegatableBoolVar(&c.match) | |||
| act.Flag("match-replies-timeout", "Timeout after which messages without a reply are printed").PlaceHolder("TIMEOUT").DurationVar(&c.matchTimeout) | |||
There was a problem hiding this comment.
I'd love to set this to a (low?) default.
There was a problem hiding this comment.
Rather just use the overall timeout set with --timeout, dont think its needed add more ways to set timeouts. That one already have a default.
Still, I am not sure if I want to add this, will give it some thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.