Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a Provider should not delete associated RawNotifications and ParsedNotifications #157

Open
glennmatthews opened this issue Nov 16, 2021 · 1 comment

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Nautobot version: 1.1.4
  • nautobot-circuit-maintenance version: 0.3.2

Expected Behavior

On deleting a Provider, circuit-maintenance records should not be auto-deleted, although any references to that Provider should be nulled out.

Observed Behavior

Deleting a Provider deletes all of its associated RawNotifications and ParsedNotifications, although CircuitMaintenances remain present since they are linked to Circuits rather than Providers.

Steps to Reproduce

This happened in a user environment where, due to provider mergers and name changes, we had multiple Provider records that actually referred to the same company. After migrating all relevant Circuits to the correct single, consolidated, Provider record, I deleted the old Provider which no longer had any associated Circuits. To my surprise, this also deleted a slew of older RawNotifications and ParsedNotifications as they were associated to the old Provider still. The result is that I still have valid CircuitMaintenance records (since the Circuits were not deleted and are now associated to the new provider) but no longer any references to the parsed data that originated these records.

I would have preferred for the old RawNotification and ParsedNotification records to remain available, presumably with null provider references, rather than being deleted.

@chadell
Copy link
Contributor

chadell commented Nov 17, 2021

I agree, let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants