Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Global App config options available on a per golden config setting level #842

Open
jeffkala opened this issue Dec 5, 2024 · 0 comments · May be fixed by #847
Open

Make Global App config options available on a per golden config setting level #842

jeffkala opened this issue Dec 5, 2024 · 0 comments · May be fixed by #847
Assignees

Comments

@jeffkala
Copy link
Contributor

jeffkala commented Dec 5, 2024

Environment

  • Nautobot version: 2.2+
  • nautobot-golden-config version: next

Today the app is configured to hide views, menu items, etc. based on the global config settings e.g.

ENABLE_COMPLIANCE=True
ENABLE_INTENDED=True
ENABLE_BACKUP=True
ENABLE_SOTAGG=True
ENABLE_POSTPROCESSING=True
ENABLE_PLAN=True
ENABLE_DEPLOY=True

This lacks the flexibility some multi-vendor environments (specifically with a mix of CLI and controller based) platforms need. It would be great to move these ENABLE features into each GC setting.

Proposed Functionality

  • Remove all the conditional logic throughout the app that is based on ENABLE features options. This moves the app more in line with what all other apps, core do today, still show the object, nav in UI, if you don't use them then you don't use them. (furthermore, if users want this they can now accomplish it view saved views)
  • Add toggle options on the golden config setting itself for each of the ENABLE feature options.
    • Have a default boolean of sorts that defaults the default GC setting to what is in plugin_config.

To provide an example of the new GC settings view.
Screenshot 2024-12-05 at 9 53 58 AM

Use Case

  • All backup, intended, compliance on a GC setting but don't allow config plans or deploys (since a controller must do it in those cases)
  • I don't use GC for backups, but a custom job pulls the backup data into nautobot, I still want the UI views, and nav menu to show models that I may use in a backup "post processing" of sorts.
@jtdub jtdub self-assigned this Dec 11, 2024
@jtdub jtdub linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants