Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of errors in contrib #628

Open
Tracked by #629
Kircheneer opened this issue Dec 12, 2024 · 1 comment
Open
Tracked by #629

Improve handling of errors in contrib #628

Kircheneer opened this issue Dec 12, 2024 · 1 comment
Labels
integration: contrib Contrib related issues and PRs status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement New feature or request

Comments

@Kircheneer
Copy link
Contributor

Proposed Functionality

Upon failed object validation in create, update, or delete, raise the appropriate diffsync.exceptions.ObjectCrudException subclass (ObjectNotCreated, ObjectNotUpdated, ObjectNotDeleted). Include as much context as possible so the error can be acted upon.

Use Case

Instead of crashing the entire SSoT run, this singles out failures in individual CRUD operations and allows them to be properly logged.

This also enables the data validation engine integration.

@Kircheneer Kircheneer added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement New feature or request integration: contrib Contrib related issues and PRs labels Dec 12, 2024
@Kircheneer
Copy link
Contributor Author

On second thought, in nautobot_ssot.contrib this is already happening, and that is all we can enforce. We should however, document the existence of this mechanism and what it entails.

@Kircheneer Kircheneer mentioned this issue Dec 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: contrib Contrib related issues and PRs status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant