Skip to content

Commit

Permalink
Merge pull request #92 from nautobot/release-0.3.1
Browse files Browse the repository at this point in the history
Release 0.3.1
  • Loading branch information
gsnider2195 authored Aug 22, 2024
2 parents a42a566 + c45a8c5 commit 468a8dc
Show file tree
Hide file tree
Showing 37 changed files with 785 additions and 835 deletions.
9 changes: 0 additions & 9 deletions .flake8

This file was deleted.

45 changes: 13 additions & 32 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
APP_NAME: "pylint-nautobot"

jobs:
black:
ruff-format:
runs-on: "ubuntu-latest"
env:
INVOKE_PYLINT_NAUTOBOT_LOCAL: "True"
Expand All @@ -25,20 +25,9 @@ jobs:
uses: "actions/checkout@v4"
- name: "Setup environment"
uses: "networktocode/gh-action-setup-poetry-environment@v6"
- name: "Linting: black"
run: "poetry run invoke black"
bandit:
runs-on: "ubuntu-latest"
env:
INVOKE_PYLINT_NAUTOBOT_LOCAL: "True"
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- name: "Setup environment"
uses: "networktocode/gh-action-setup-poetry-environment@v6"
- name: "Linting: bandit"
run: "poetry run invoke bandit"
ruff:
- name: "Linting: ruff format"
run: "poetry run invoke ruff --action format"
ruff-lint:
runs-on: "ubuntu-latest"
env:
INVOKE_PYLINT_NAUTOBOT_LOCAL: "True"
Expand All @@ -60,17 +49,6 @@ jobs:
uses: "networktocode/gh-action-setup-poetry-environment@v6"
- name: "Check Docs Build"
run: "poetry run invoke build-and-check-docs"
flake8:
runs-on: "ubuntu-latest"
env:
INVOKE_PYLINT_NAUTOBOT_LOCAL: "True"
steps:
- name: "Check out repository code"
uses: "actions/checkout@v4"
- name: "Setup environment"
uses: "networktocode/gh-action-setup-poetry-environment@v6"
- name: "Linting: flake8"
run: "poetry run invoke flake8"
poetry:
runs-on: "ubuntu-latest"
env:
Expand All @@ -95,16 +73,15 @@ jobs:
run: "poetry run invoke yamllint"
pylint:
needs:
- "bandit"
- "ruff"
- "flake8"
- "poetry"
- "yamllint"
- "black"
- "ruff-format"
- "ruff-lint"
runs-on: "ubuntu-latest"
strategy:
fail-fast: true
matrix:
# TODO: Update to 3.12 once #89 is implemented
python-version: ["3.11"]
nautobot-version: ["stable"]
env:
Expand Down Expand Up @@ -141,10 +118,14 @@ jobs:
fail-fast: true
matrix:
python-version: ["3.11"]
nautobot-version: ["1.6", "2.0", "2.1"]
# Incompatible with 2.2.3-2.3.0 due to https://github.com/nautobot/nautobot/pull/6116
nautobot-version: ["1.6", "2.0", "2.1", "2.2.2", "2.3"]
include:
- python-version: "3.8"
nautobot-version: "2.1"
nautobot-version: "stable"
# TODO: Enable once #89 is implemented and remove 2.3 from matrix
# - python-version: "3.12"
# nautobot-version: "stable"
runs-on: "ubuntu-latest"
env:
INVOKE_PYLINT_NAUTOBOT_PYTHON_VER: "${{ matrix.python-version }}"
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -306,3 +306,7 @@ invoke.yml
public
/compose.yaml
/pylint-nautobot/static/nautobot_firewall_models/docs

# Vagrant
.vagrant
Vagrantfile
1 change: 0 additions & 1 deletion development/docker-compose.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ x-nautobot-base: &nautobot-base
image: "pylint-nautobot/nautobot:${NAUTOBOT_VER}-py${PYTHON_VER}"
tty: true

version: "3.8"
services:
nautobot:
<<:
Expand Down
1 change: 0 additions & 1 deletion development/docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# any override will need to include these volumes to use them.
# see: https://github.com/docker/compose/issues/3729
---
version: "3.8"
services:
nautobot:
volumes:
Expand Down
5 changes: 4 additions & 1 deletion development/nautobot_config.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
"""Nautobot development configuration file."""
SECRET_KEY = "NOTASECRET" # nosec

from nautobot.core.settings import * # noqa: F403 # pylint: disable=wildcard-import,unused-wildcard-import

SECRET_KEY = "NOTASECRET" # noqa: S105
2 changes: 1 addition & 1 deletion docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The project is packaged with a light development environment using `invoke` task

The project is following Network to Code software development guidelines and is leveraging the following:

- Python linting and formatting: `black`, `pylint`, `bandit`, `flake8`, and `pydocstyle`.
- Python linting and formatting: `pylint` and `ruff` (which includes rules from `bandit`, `flake8`, and `pydocstyle`).
- YAML linting is done with `yamllint`.
- Python unit tests to ensure the rules are working properly.

Expand Down
16 changes: 14 additions & 2 deletions docs/release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,26 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.3.1] - 2024-08-22

### Changed

- Remove `Tables` from fields `__all__` check (nautobot-use-fields-all) and add tests ([#83](https://github.com/nautobot/pylint-nautobot/pull/83))

### Housekeeping

- Removed upper bound on Python version ([#88](https://github.com/nautobot/pylint-nautobot/pull/88))
- Added upper bound on pylint version (due to #89) ([#88](https://github.com/nautobot/pylint-nautobot/pull/88))
- Switched tooling to `ruff` as per changes to the Nautobot App Template and removed `flake8`, `pydocstyle`, and `bandit` ([#88](https://github.com/nautobot/pylint-nautobot/pull/88))

## [0.3.0] - 2024-03-05

### Added
### Added

- Added `nb-use-fields-all` rule (#70)
- Added `nautobot-sub-class-name` rule (#74)

### Changed
### Changed

- Improve incorrect base class checker (#72)
- Update CODEOWNERS (#68)
Expand Down
Loading

0 comments on commit 468a8dc

Please sign in to comment.