Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] about MST Initialization in Global Aligner #164

Open
yukiumi13 opened this issue Aug 18, 2024 · 0 comments
Open

[QUESTION] about MST Initialization in Global Aligner #164

yukiumi13 opened this issue Aug 18, 2024 · 0 comments

Comments

@yukiumi13
Copy link

Thank you for your excellent work on this project.

I am having some confusion regarding the initialization process in the following lines of code:

while todo:
# each time, predict the next one
score, i, j = todo.pop()
if im_focals[i] is None:
im_focals[i] = estimate_focal(pred_i[i_j])

It appears that a new edge (i, j) is popped, but the variable i_j is not updated accordingly. Additionally, it seems that the estimated focal length of the legacy i is being assigned to the newly popped i view. Could you please clarify if this is the intended behavior or if there might be an issue here?

I would appreciate any insights you can provide to help me understand this better.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant