Fix order completion logic in OrganisasjonBestillingService

#deploy-test-dolly-backend The previous logic incorrectly assumed orders with empty status lists were completed. This change ensures an order is only marked as completed if the status list is not empty and all statuses indicate completion.
navikt · Sep 16, 2024 · 2fba5fb · 2fba5fb
1 parent 364cfbc
commit 2fba5fb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/apps/dolly-backend/src/main/java/no/nav/dolly/service/OrganisasjonBestillingService.java b/apps/dolly-backend/src/main/java/no/nav/dolly/service/OrganisasjonBestillingService.java
@@ -250,7 +250,7 @@ private void updateBestilling(OrganisasjonBestilling bestilling, List<OrgStatus>
 
         bestilling.setFeil(feil);
 
-        var ferdig = orgStatus.stream()
+        var ferdig = !orgStatus.isEmpty() && orgStatus.stream()
                 .allMatch(o -> DEPLOY_ENDED_STATUS_LIST.stream()
                         .anyMatch(status -> status.equals(o.getStatus()))) &&
                 Arrays.stream(bestilling.getMiljoer().split(","))