Lagt til logging av CallId i kall mot pensjon #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krharum
approved these changes
Mar 14, 2024
| public Flux<PensjonforvalterResponse> lagreInntekter(PensjonPoppInntektRequest pensjonPoppInntektRequest) { | ||
|
|
||
| log.info("Popp lagre inntekt {}", pensjonPoppInntektRequest); | ||
| String callId = generateCallId(); |
There was a problem hiding this comment.
Nå når callId også skal logges kunne det være et alternativ å flytte loggingen inn i command-fil, istedet for å introdusere et parameter til. Det vil være enklere å lese og vedlikeholde, men dette er også OK.
(så lite kode som mulig bør være målet 😄 )
| public Flux<PensjonforvalterResponse> annullerSamboer(String ident, String periodeId, String miljoe) { | ||
|
|
||
| log.info("Pensjon samboer annuller {} periodeId {}", ident, periodeId); | ||
| String callId = generateCallId(); |
There was a problem hiding this comment.
Bruk generelt var på venstre side av variabelnavn, lettere å lese og vedlikeholde. (Noen ganger er det gode grunner til å ha eksplisitt type dog.)
# Conflicts: # apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/command/LagreAlderspensjonCommand.java # apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/command/LagrePoppInntektCommand.java # apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/command/LagreTpForholdCommand.java # apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/command/LagreTpYtelseCommand.java # apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/command/LagreUforetrygdCommand.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.