Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video playback tracking for YouTube #4

Open
joehobson opened this issue Jul 29, 2015 · 5 comments
Open

Video playback tracking for YouTube #4

joehobson opened this issue Jul 29, 2015 · 5 comments
Assignees

Comments

@joehobson
Copy link
Member

After #3 is completed, implement GA tracking events for video playback, like you did on the OET theme update recently.

@joehobson
Copy link
Member Author

any luck finishing these youtube issues so we can send an update to the production server?

@johnpaulbalagolan
Copy link
Contributor

Hi Sir,

Sorry had some relatives came in late Friday until the weekend. I have just resumed working today. I will get this up today.

Thanks.

@johnpaulbalagolan
Copy link
Contributor

We just had our power back. I have committed the latest code with the fix to this issue. Fixed #4.

Thanks.

@joehobson
Copy link
Member Author

Check again... I don't think you pushed your commit. Also, bump up the version number to 0.2.6 so it's easier to tell when the plugin is updated in WP Admin. Thx

@johnpaulbalagolan
Copy link
Contributor

I committed it to my forked copy last night. I actually created a pull request earlier because I was getting error committing the codes to github. But after several retries, I was able to push it successfully to the main repository. It's now up-to-date.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants