Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH ED] Code Review A Colleague's TV Show Project #219

Open
nazaninsaedi opened this issue May 3, 2024 · 3 comments
Open

[TECH ED] Code Review A Colleague's TV Show Project #219

nazaninsaedi opened this issue May 3, 2024 · 3 comments

Comments

@nazaninsaedi
Copy link
Owner

From Module-JS3 created by SallyMcGrath: CodeYourFuture/Module-JS3#10

Link to the coursework

https://github.com/CodeYourFuture/tv-show-dom-project

Why are we doing this?

Assignment: Complete a code review of a colleague's project.

You should by now have seen quite a few of your colleague's TV Show Projects. What project have you been most interested in? What solutions have you learned the most from? What lessons will you take into your own practice? You might have noticed:

  • a really great layout
  • a clever use of array methods
  • readable code with small clearly named functions
  • something else

Check out the Financial Times competency on Engineering Communication to understand why developing this skill is so important.

Maximum time in hours (Tech has max 16 per week total)

3

How to get help

Read the GitHub docs on reviewing pull requests

How to submit

Your submission should be in the form of a code review on a colleague's TV Show Project. Attach a link to this ticket.

Anything else?

https://syllabus.codeyourfuture.io/guides/code-style-guide

@nazaninsaedi
Copy link
Owner Author

@nazaninsaedi
Copy link
Owner Author

@nazaninsaedi nazaninsaedi moved this from 🔖 Ready to ✅ Done in Coursework Planner Board May 5, 2024
@nazaninsaedi nazaninsaedi moved this from ✅ Done to 👀 In review in Coursework Planner Board May 5, 2024
@JayMayer
Copy link

@nazaninsaedi These code reviews are very clearly written by AI, and don't make sense in the context of the TV Show project. Whilst using AI can be very beneficial, it makes it difficult to demonstrate your own skills and knowledge for writing good code reviews. This is an essential skill for developers of all levels, so I would encourage you to try writing out a code review without the use of AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants