-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal window moves slightly sideways when opening and closing in browser with scroll bar. #9
Comments
Hi @moonjoungyoung, thanks for the bug report! If you go to http://getbootstrap.com/docs/4.1/components/modal/#live-demo and click on "Launch demo modal", do you see the same behavior on Windows? The reason I ask is that as far as I can tell, react-bootstrap4-modal doesn't do anything that would affect this, so the behavior may be an underlying issue in Bootstrap itself. |
Hello @nbudin, Thanks for the comment. This does not happen in pure versions, such as GIF above. |
Hello @nbudin, can I know how is it going? |
Hi @moonjoungyoung! I don’t have access to a Windows machine, so I have no usable way to reproduce the issue myself. If you’re able to discover the cause and figure out how to fix it, I would be very glad to review a pull request, but as it stands I don’t think I can fix this myself. |
Hi Unfortunately I cannot share the code where i`m having this issue with. I might try to make a demo later, to help with investigations. Still, just wanted to give a heads up that this is happening on macOS as well |
The same thing happened to me Update |
@bohdanbirdie Would you mind saying more about what in your styles caused the problem? It might be helpful for other people dealing with this issue. |
@nbudin np .modal-dialog {
max-height: 90%;
max-width: $modal-width;
// width: 130%;
// display: flex;
// margin: 0;
// justify-content: center;
// align-items: flex-start;
} |
@nbudin Sorry, misunderstood your message |
For anyone having a similar issue - I had this issue where my website moved sideways on opening and closing the modal and the issue was because i had a style like this:
which caused that when i opened the modal, the scrollbar disapeared, website widened and then a padding-right:17px was added to the body element by bootstrap javascript and the whole thing was animated.
so the resizing happened instantly and there are no visual effects of it happening. |
As you can see, when you open and close a modal window, the scroll bar disappears and then rises, and the window moves slightly.
Detected in Windows 10, Chrome 65.
It is not observed on MAC, which is thought to be due to the render method of the scroll bar.
The text was updated successfully, but these errors were encountered: